Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed tag not showing up after removal when using "x" button #9563

Merged
merged 2 commits into from
Aug 9, 2023
Merged

fixed tag not showing up after removal when using "x" button #9563

merged 2 commits into from
Aug 9, 2023

Conversation

grimmoc
Copy link
Contributor

@grimmoc grimmoc commented Aug 9, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Aug 9, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review August 9, 2023 14:45
@JammingBen JammingBen merged commit c712af9 into master Aug 9, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the 9356-9362-tag-form-improvements branch August 9, 2023 14:45
AlexAndBear pushed a commit that referenced this pull request Aug 15, 2023
@grimmoc
fixed tag not showing up after removal when using "x" button (#9563)
0067b03 
* fixed tag not showing up after removal when using "x" button

* edited changelog
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@grimmoc @AlexAndBear
fixed tag not showing up after removal when using "x" button (#9563)
7325541 
* fixed tag not showing up after removal when using "x" button

* edited changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grimmoc @dschmidt @JammingBen